The original path used to import @novnc/novnc libraries on the client side were through the path node_modules/@novnc/novnc/core as those files were available in the location until 1.4.0.
There is a package structure change in @novnc/novnc where files are no longer available under node_modules/@novnc/novnc/core; instead, the files are solely available under node_modules/@novnc/novnc/lib. When we run npm install in <iCtrl-root>/client, npm dependency resolution decides that 1.5.0 should be installed instead of 1.4.0, which causes our source imports to break.
To address the issue, this PR:
Upgrade @novnc/novnc version to ^1.5.0 to ensure the dependency is also 1.5.0 or above when our iCtrl/client project is initiated with other package managers (e.g., pnpm).
Update import paths in iCtrl/client source files to reflect the path changes.
The original path used to import
@novnc/novnclibraries on the client side were through the pathnode_modules/@novnc/novnc/coreas those files were available in the location until 1.4.0.There is a package structure change in
@novnc/novncwhere files are no longer available undernode_modules/@novnc/novnc/core; instead, the files are solely available undernode_modules/@novnc/novnc/lib. When we runnpm installin<iCtrl-root>/client, npm dependency resolution decides that 1.5.0 should be installed instead of 1.4.0, which causes our source imports to break.To address the issue, this PR:
@novnc/novncversion to^1.5.0to ensure the dependency is also 1.5.0 or above when our iCtrl/client project is initiated with other package managers (e.g.,pnpm).