junhewk / RcppMeCab

RcppMeCab: Rcpp Interface of CJK Morpheme Analyzer MeCab
24 stars 8 forks source link

Fix Makevars and add test #8

Closed paithiov909 closed 3 years ago

paithiov909 commented 3 years ago

Summary

This PR aims to fix things below.

  1. Installing the package fails when using 64bit MeCab on Windows machine
  2. Close #7
  3. Add test by Travis CI
  4. Fix typo and format code

Details

Installing problem on 64bit Windows

Because the libmecab.dll as which is gzipped in mecab64_ja.tar.gz is corruputed, generated RcppMecab.dll does not work properly on 64bit R running on Windows machine (and that seems why pos returns just empty list here).

This PR replaces the content (SHA256:125360C7A0C091F44D25B815267670D170EF2AB2942F287D6AA21B24A2D14FE9) of mecab64_ja.tar.gz with another DLL file (SHA256:9E74E6BD227396B1D57D678B7A0F90493F3CBD6E02C542DE48FFCFC901851590). That file originally comes from this unoffical build.

Test on Travis CI

Testing for both cases that MECAB_LANG="ja" is setted and not setted. See the results.