change download url of mecab binary

junhewk / RcppMeCab

RcppMeCab: Rcpp Interface of CJK Morpheme Analyzer MeCab

24 stars 8 forks source link

change download url of mecab binary #9

Closed paithiov909 closed 3 years ago

paithiov909 commented 3 years ago

Hi @junhewk, thank you for reviewing my previous PR #8.

I made some commits, altering mecab download url to https://raw.githack.com/junhewk/RcppMeCab/master/mecab/win$(R_ARCH)/mecab$(WIN)_$(MECAB_LANG).tar.gz, and so on.

Please review it, then squash and merge the PR.

junhewk commented 3 years ago

Is there any reason that you close the request? I had a quite busy schedules to check the commit, so I couldn't reply promptly. Sorry about that.

paithiov909 commented 3 years ago

I noticed that my PR #8 and #9 had a problem when you try to install the package at first time under windows (and that why I closed this PR myself). I will make another PR to fix them, please check it when you have enough time.

junhewk commented 3 years ago

@paithiov909 I tested your commit in my local system (Windows 10, Korean, never installed R and RcppMeCab packages) and it worked well. So, I merged your commit to the master branch. I cannot test the package in Japanese Windows setting, so please feel free to edit the lines.