search

junhoyeo / react-native-bubble-tabbar

🧼 Bubble Tab Bar Component for React Native which supports React Navigation V5 and TypeScript
MIT License
52 stars 7 forks source link

Fix: dynamic tabs length #12

Closed abathz closed 3 years ago

abathz commented 3 years ago

Hello there 👋🏻

I just fixing tabs length for app with more than 4 bottombar issue. I got an issue when i want to add more bottombar icon in this library, so i decide to PR this commit for fix.

I just improve 1 line code for javascript slice method in this library.it makes user cannot adding more bottombar again because this library limit the bottombar to 4 icon. I change tabs.slice(0,4) to tabs.slice(0, tabs.length) for dynamic.

please take a look, thanks! have a nice day🎉🎉

junhoyeo commented 3 years ago

Thanks, @abathz! I apologize for not maintaining this project well 🙏 I'll review your PR today after work. 👍 😁

abathz commented 3 years ago

Thanks no problem, @junhoyeo! 👍 😁

junhoyeo commented 3 years ago

@abathz Sorry to keep you waiting! I wanted to make sure that we can manage the code styles first, to keep the codebase style consistent. I merged your PR, and you can check it with the latest release, 0.1.0! 😄