junhoyeo / react-native-bubble-tabbar

๐Ÿงผ Bubble Tab Bar Component for React Native which supports React Navigation V5 and TypeScript
MIT License
52 stars 7 forks source link

[Feature request] add ui kitten eva-icons support #4

Open kockok opened 4 years ago

kockok commented 4 years ago

Hi, I'm using the ui-kitten icons.

const evaIconRenderer = ({icon}: IIconRenderer) => <Icon name={icon} />;

const CustomTabBar: React.FC<BottomTabBarProps> = ({
  state,
  descriptors,
  navigation,
}) => {
  return (
    <BubbleTabBar
      state={state}
      descriptors={descriptors}
      navigation={navigation}
      tabs={tabs}
      iconRenderer={evaIconRenderer}
    />
  );
};

Even with the iconRenderer, I cannot get the icons show up.

Possibly this is due to the fact that eva icon is rendering icons with JSX elements.

The active highlight becomes eerily big. Screenshot 2020-07-19 at 12 06 10 AM

junhoyeo commented 4 years ago

@kockok, Thanks for the issue & sorry for the late reply. Hadn't check my inbox,, ๐Ÿ˜ฐ I promise to investigate it tommorrow ! ๐Ÿš€