search

junian / Standard.Licensing

Easy-to-use licensing library for .NET Framework, Mono, .NET Core, and MAUI / Xamarin products
https://junian.dev/Standard.Licensing/
MIT License
554 stars 127 forks source link

Soluton errors #15

Open sylvainonweb opened 4 years ago

sylvainonweb commented 4 years ago

Hi,

I retrieve the solution and try to compile it but I encounter the following errors : 1) 

MSB4019 The imported project "C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\MSBuild\Microsoft\Portable\v4.5\Microsoft.Portable.CSharp.targets" was not found. Confirm that the expression in the Import declaration "C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\MSBuild\Microsoft\Portable\v4.5\Microsoft.Portable.CSharp.targets" is correct, and that the file exists on disk.   Standard.Licensing  C:\Program Files\dotnet\sdk\3.1.101\Sdks\Microsoft.NET.Sdk\Sdk\Sdk.targets  37

=> I had to change the TargetFramework from this to this but don't think it's the right solution

    Before : <TargetFrameworks>netstandard2.0;netstandard1.3;netstandard1.0;net45;net40;portable-net45+win8+wpa81+wp8;portable-net403+sl50+win8+wp8;</TargetFrameworks>-->
    After :: <TargetFrameworks>netstandard2.0;netstandard1.3;netstandard1.0;net45;net40;</TargetFrameworks>

2) The Standard.Licensing.Tests project wasn't in the solution. => I add it and add the following nuget packages : System.Xml.Linq, System.Xml.ReaderWriter, NUnit

3) After that, the Standard.Licensing.Tests project compile but no test is runned

Is there a chance you can help me on these points?

ConnerPhillis commented 4 years ago

Not the author, and only wrote a little code for a PR a while ago. 1) you might not have the mobile toolkit installed for visual studio, you can download it with the installer. I do have it but I still never got the thing to compile. 2) (&3) the reason it isn't referenced and isn't running tests is because there aren't actually any tests written against the library. Maybe it was a to do item from a while ago that never got taken care of.