nus-se-bot
commented
1 year ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Wrong json url does not result in error
Editing the url in json storage to not follow the format as stated does not result in error (ww. instead of www.)
[original: nus-cs2103-AY2223S2/pe-interim#1884] [original labels: type.FunctionalityBug severity.Medium]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Directly editing data files is meant for advanced users and should be done at their own risk.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [x] I disagree
Reason for disagreement: The issues caused by a corrupted tag and a corrupted library are 2 separate matters.
## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** There is are NO WARNING MESSAGES when the "library" JSON file is corrupted. The error warning is incorrect. It does not "discard all data and start with an empty data file at the next run", instead it keeps the corrupted data file on subsequent runs until a command causes a modification to the corrupted file.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.High`] - [x] I disagree **Reason for disagreement:** Encountering this issue will completely erase all stored bookmarks with no warning messages.
Messing with the data files can cause the App to not display any data without throw errors of file corruption.
Immediately opening
Casually adding a new bookmark...
All data overwritten....
This can be disastrous if the user is not aware and adds in a new bookmark after modifying his library. If he has a large amount of bookmarks, they're now all gone.
An error message can be thrown instead and provide a warning that adding new bookmarks will completely override the old corrupted data.