junichi11 / netbeans-change-lf

Change line endings on save.
https://plugins.netbeans.apache.org/catalogue/?id=31
Other
16 stars 3 forks source link

Made captions of controls consistent with other plugins. #6

Closed kelemen closed 11 years ago

junichi11 commented 11 years ago

This is OK. But I would like to unify the name (line feed code). Why did you change "line feed (code)" to "line endings"?

kelemen commented 11 years ago

First, it is consistent with the "Show and change line endings" plugin. Also, I find line feed misleading because it implies the LF character. Line ending is a more general term.

junichi11 commented 11 years ago

I see. But it is not good that it has some names in source code. e.g.

My problem is not name for it but unification for name.

kelemen commented 11 years ago

Sorry, I forgot about that one. Should I change it as well?

junichi11 commented 11 years ago

Yes, also README file, if you would like to use line endings.

kelemen commented 11 years ago

I will adjust the pull request according to your remarks. Though I will only do it tomorrow (or rather after sleep :)). It is just too late now, or perhaps too early here :)

junichi11 commented 11 years ago

Thanks for your request. Good night :smile:

kelemen commented 11 years ago

I have adjusted the labels. If you don't mind, I have also changed the display name of the plugin.

junichi11 commented 11 years ago

In case of windows(CRLF), Whole label is not shown. So I'll adjust the size.

Thanks a lot!