Multiple fixes, bump default to 0.8.3

[juniorsysadmin]

(Thanks to @fkleon for raising some of these)

• Applies modulesync changes (from Voxpupuli modulesync_configs).
• Changes default version to 0.8.3.
• Adds new configuration parameters for 0.8.x.
• Splits off the nginx.conf contents into a new variable.
• Cleans up the kong.yml template, double quoting variables and removes (most) commented sections taken from the default upstream file.
• Adds better documentation for parameters.
• Changes validation of certain IP addresses to IPv4 only.
• Adds validation of the database type.
• Adds dns_resolvers_available parameter.
• Replaces proxy_listen_address and proxy_listen_port parameters with proxy_listen.
• Replaces proxy_listen_ssl_address and proxy_listen_ssl_port parameters with proxy_listen_ssl.
• Replaces admin_api_listen_address and admin_api_listen_port parameters with admin_api_listen.
• Replaces cluster_listen_address and cluster_listen_port parameters with cluster_listen.
• Replaces cluster_listen_rpc_address and cluster_listen_rpc_port parameters with cluster_listen_rpc.
• Changes config_file_group to 0 rather than root in preparation for FreeBSD support.
• Adds better validation of parameters.
• Adds staging_dir parameter.
• Fixes custom_plugins to be empty since supported plugins are loaded by default.
• Fixes printing of cassandra_ssl_* values.
• Fixes metadata.json formatting.
• Fixes variable quoting in initscripts.pp.
• Fixes the Upstart script to include start.
• Fixes inconsistent Puppet-managed template headers.
• Fixes installation issues due to the native package provider not supporting the source package attribute.
• Attempts to fix up non-working OSX installation.

[juniorsysadmin]

@fkleon This should also include most of the changes in #1 . I have left the database parameters as they are rather than making them generic as I want them to directly relate to the Kong variables. I am missing some newer 0.8.x parameters as well, so further changes to this branch are likely.

[fkleon]

This is looking great, I'll close #1 in favour of this one.

[juniorsysadmin]

@fkleon I'm more or less done with this Pull Request for now, so unless there are major objections, I'll squash commits, merge and cut a new release this week.

[fkleon]

I've tried this branch on our setup, and apart from the configuration file issues it seems to work fine.

I noticed another issue on our particular setup (Ubuntu 14.04): In install.pp, if package_manage and manage_package_fetch are true (default), Kong is supposed to be installed from the *.deb file. However, on Ubuntu the apt provider is auto-selected by Puppet, which does not support installation from a file.

I had to work around that by overriding the provider for that specific package with the following collector:

  Package<|title == 'kong'|> {
    ensure   => latest,
    provider => 'dpkg',
  }

The dpkg provider does not supported versioned packages, so I had to override ensure as well. Not sure what the best fix would be, but it should probably at least be documented somewhere.

[juniorsysadmin]

@fkleon Integer quoting has been fixed. I need to think about the packaging one - that is..yuck.

[juniorsysadmin]

@fkleon I've just pushed an attempted fix for package installation

[fkleon]

One last issue with the kong.yml template around the postgres port. Installation works fine now, thanks!

[juniorsysadmin]

One last issue with the kong.yml template around the postgres port. Installation works fine now, thanks!

Fixed and commits squashed