search

juniorsysadmin / puppet-kong

Installs and configures Kong
Apache License 2.0
1 stars 9 forks source link

Fix for install on every puppet run and install from package manager #8

Closed davideagle closed 8 years ago

davideagle commented 8 years ago

There was a bug resulting in the module trying to install kong on every puppet run and it caused that if $kong::manage_package_fetch was not set to true the package would not be installed from the package manager which I suspect should be the expected behaviour.

juniorsysadmin commented 8 years ago

@davideagle Thanks for this. I have modified this approach slightly in #10 by using a selector. Let me know if you're happy with the new Pull Request fix.

davideagle commented 8 years ago

Seems fine to me :)

On Sat, Jun 18, 2016 at 8:38 AM, Ben S notifications@github.com wrote:

@davideagle https://github.com/davideagle Thanks for this. I have modified this approach slightly in #10 https://github.com/juniorsysadmin/puppet-kong/pull/10 by using a selector. Let me know if you're happy with the new Pull Request fix.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/juniorsysadmin/puppet-kong/pull/8#issuecomment-226929741, or mute the thread https://github.com/notifications/unsubscribe/ACu9VBMiKcsTseDoWJAV_TrzYma689JYks5qM66EgaJpZM4I3aC_ .

juniorsysadmin commented 8 years ago

Closed in favor of #10