search

juniorxsound / Depthkit.js

🎞 A plugin for using DepthKit's volumteric captures in Three.js
https://juniorxsound.github.io/Depthkit.js/
MIT License
89 stars 34 forks source link

Three Geometry is deprecated and removed port to BufferGeometry #21

Closed arpu closed 1 year ago

arpu commented 3 years ago

Hey,

any plans to support THREEjs BufferGeometry?

ROBYER1 commented 1 year ago

Wondering this too

ROBYER1 commented 1 year ago

Try this branch https://github.com/juniorxsound/Depthkit.js/tree/dependabot/npm_and_yarn/three-0.137.0

ROBYER1 commented 1 year ago

I failed to get anything working with that branch as that branch only pulled in dependencies. Instead I went ahead and tried to convert the THREE.Geometry to THREE.BufferGeometry myself but I'm still having trouble getting it to render correctly.

I have started a fork for this here https://github.com/ROBYER1/Depthkit.jsBufferGeometry if anyone wants to try and help out? I'm genuinely really stuck and might just opt to not use DepthKit in the future.

I have also asked about this on stackoverflow here https://stackoverflow.com/questions/74693660/how-to-convert-three-geometry-to-three-buffergeometry-from-face3

juniorxsound commented 1 year ago

Hi 👋 thanks for opening this issue.

Totally agree we should migrate over to BufferGeometry - I currently have no bandwidth to do that but if anyone wants to open a PR i'd be happy to review and provide some feedback

ROBYER1 commented 1 year ago

Hi 👋 thanks for opening this issue.

Totally agree we should migrate over to BufferGeometry - I currently have no bandwidth to do that but if anyone wants to open a PR i'd be happy to review and provide some feedback

Just cracked it here, hopefully can be merged, just need to build depthkit.min,js because I wasn't sure how to do that but I rebuilt depthkit.js in build folder https://github.com/juniorxsound/Depthkit.js/pull/30

juniorxsound commented 1 year ago

@ROBYER1 @arpu this has now been merged 🙏

ROBYER1 commented 1 year ago

Thanks! I was going to look into fully updating to the very latest Three.js but hit some other issues there, this works good for what I needed though!

ROBYER1 commented 1 year ago

I forgot to add, I got DepthKit.js running in Needle which has support for desktop/AR/MR/VR Needle Example: https://outgoing-exuberant-cheshire.glitch.me/

More about Needle: https://needle.tools/