juniorxsound / Depthkit.js

🎞 A plugin for using DepthKit's volumteric captures in Three.js
https://juniorxsound.github.io/Depthkit.js/
MIT License
89 stars 34 forks source link

Plugin refactor RFC #36

Open juniorxsound opened 1 year ago

juniorxsound commented 1 year ago

It's been a moment since this plugin was last maintained and quite a lot has changed so wanted to collect some thoughts on potential future improvements.

remmel commented 1 year ago

I can migrate the code to es6 / esm (A build system won't be needed in that case). However I can also add a webpack build system to create an UMD build (w/o THREE) for thoses who don't want to use esm from browser (the only usage I see is, when using aframe lib direcly without aframe-dephkit component ; note that es6 as es-module-shims make esm available ~everywhere)

ROBYER1 commented 1 year ago

npm package + Typescript + Vite plugin system as an ES module would be essential for my work projects using Needle Tools and other things using Vite.

Support for newer depthkit metadata structure is also essential for use of up to date versions. Thanks for your work on this!

remmel commented 1 year ago

@ROBYER1 Why do you need depthkit to use typescript and vite? Your project should not be dependent on the build system of the library it uses. For example you are using THREE which is built with esm and rollup

ROBYER1 commented 1 year ago

@ROBYER1 Why do you need depthkit to use typescript and vite? Your project should not be dependent on the build system of the library it uses. For example you are using THREE which is built with esm and rollup

Makes sense to me, I'm still figuring out a lot of Vite but thanks for the explanation!