juniperparsnips / rink-runtime

Rust implementation of inkle's open source scripting language runtime engine.
MIT License
1 stars 2 forks source link

Make types closer to semantics #13

Closed IFcoltransG closed 1 year ago

IFcoltransG commented 1 year ago

Review of the types that are deserialized from JSON. Adjusted to be closer to Ink runtime's actual semantics.

I also deleted unnecessary refs and borrows from the functions I was already changing — they aren't idiomatic Rust anymore.

juniperparsnips commented 1 year ago

There's a few compiler and test errors with the updated external args, but otherwise everything looks good and we can merge after they're fixed

IFcoltransG commented 1 year ago

That's embarrassing on my part. I've corrected the test cases that don't compile. One test case fails, which is the same one from #10.