search

junit-team / junit4

A programmer-oriented testing framework for Java.
https://junit.org/junit4
Eclipse Public License 1.0
8.53k stars 3.29k forks source link

Don't convert assumption failures to errors in ErrorCollector.addErro… #1702

Closed prbprbprb closed 3 years ago

prbprbprb commented 3 years ago

…r().

Provides clearer results when calling sub-methods or when wrapping tests via a Rule.

stefanbirkner commented 3 years ago

This PR would revert parts of 88f63daafb9eec076c09f532c9f0bd823a150be0 that fixed #1363.

stefanbirkner commented 3 years ago

@prbprbprb thank you for the PR. The code works as expected. From @kcooney's remarks in #1363

The expressions passed into these methods should call production code, not test code, and AssumptionViolationException should generally be thrown by test code.

The Javadoc can be improved but currently we haven't planned to build another JUnit 4 release.