search

junit-team / junit4

A programmer-oriented testing framework for Java.
https://junit.org/junit4
Eclipse Public License 1.0
8.51k stars 3.24k forks source link

Address some warnings #1731

Closed cpoerschke closed 2 years ago

cpoerschke commented 2 years ago

Used ./mvnw compile -Dmaven.compiler.showDeprecation=true to identify the warnings.

edit: alternatively #1732 splits the changes into separate commits.

kcooney commented 2 years ago

Thank you for the contribution.

Note that there may not be another release of JUnit 4.x so these changes might never be released.

That being said, keeping things tidy is nice. If you would still like to get this merged would you please split it out into three commits with messages that state what is being done (fix JavaDoc warnings [listing warnings at the end of the commit message], remove usages of deprecated org.junit.Assert.assertThat(), suppress [specific warning] in...). One pull request is fine.

cpoerschke commented 2 years ago

Thanks for the feedback! #1732 is the multi-commit alternative PR; I'm not keen on git push --force on pull requests that are already under review, hence the separate PR rather than updating of this one here. Happy to close out whichever one of them goes unmerged.

kcooney commented 2 years ago

Cool. Let's go forward with #1732