Open leonard84 opened 6 months ago
TODO: Double-check if OpenJ9 also supports JFR
Not yet, it seems:
OpenJ9 should work with jfr-polyfill
. The question is whether you'd want to add it as a default dependency, or if OpenJ9 users should add it themselves.
As a first step, we should add a CI build using OpenJ9 to run tests. I'll see to that.
As a first step, we should add a CI build using OpenJ9 to run tests. I'll see to that.
Moving the JFR events from the extra module to core would also render the extra configuration step to include junit-platform-jfr-$VERSION.jar
described in https://junit.org/junit5/docs/current/user-guide/#running-tests-listeners-flight-recorder superseded. Which in turn enables users of the junit-platform-console-standalone-$VERSION.jar variant also make use of JFR events by default.
This would've helped to evaluate #3936, and the recent deadlocks in Spock's CI builds.
Motivation
Currently,
junit-platform-jfr
provides events that are observable to standard listeners.However, it can't provide insights into low-level events, such as the exclusive resource locks.
Previously, it was decided to only introduce JFR via an optional module because it was not supported until JDK 11. A lot has changed since: JFR has been backported to openjdk8, and all current distributions support it. Plus, JDK 9 and 10 have been EOL for a long time.
Furthermore, there is the https://github.com/gradle/jfr-polyfill project that provides a no-op implementation that prevents any crashes due to
ClassNotFoundError
.Deliverables