junjiequ1459 / MealMate

Yelp clone
5 stars 0 forks source link

Issue #02 - Feature List #2

Closed keginzburg closed 1 year ago

keginzburg commented 1 year ago

MVP List

Comments

  1. Hey Rex, some work needed here as well. Your current Feature List is being hosted on your Wiki's Home Page. First, you'll need to give this its own page in your Wiki. Again, I recommend looking to the Bluebird Wiki as a guide.
  2. After that, your Feature List needs some serious work. Right now, I need a lot more information for each Feature. I'd like to see more thought and effort on these. I can provide an example. Currently, your Maps API feature lists that you'll be implementing an integration of Google Maps functionality. Before that, there's a mention of the Yelp API (which I don't recommend you use) because you should be experiencing the practice of seeding your own data. What I'd expect to see is more along the lines of:
    • Seeded businesses will be rendered on Google Map API element.
    • User will be able to interact with the API to pull up a business' show page and zoom in and out of the map.
    • User will not be required to sign in/up before using the Map feature. Hope this gives a more concrete idea.
  3. For your User Auth MVP, that should unofficially include your Splash Page as that will offer your users a chance to Sign Up or Login. I would also make a note that on unsuccessful sign up or login, errors will be rendered.
  4. Tagging onto your current Features, I'm happy with Reviews/Ratings, Search, and the Google Maps API as Features, but I would recommend Business Index/Show to be your 1st Feature. Profile Page/Saved Restaurants feels more like a Bonus, which should be listed below your first 7 Features.
  5. Also, your estimated time is only accounting for User Auth right now. You should seriously consider how much time it will take to implement each Feature. Is it CRUD and therefore will it take more time? Is it an API I have no experience with, so will I take some time researching it?

Please let me know once you have implemented these corrections/additions. Thanks.

keginzburg commented 1 year ago

Hey Rex, please revisit my above Issue. You still need to revisit your Features. On top of that, I don't expect you to use the Yelp API to pull data. Instead, we expect you to seed the data yourself.

So, for your four Main Features, we expect: Business Index/Show, Reviews/Ratings, Search, and the Google Maps API. Then Profile as a Bonus.

junjiequ1459 commented 1 year ago

Sounds good, POST isn't possible with the Yelp API. I plan downloading their Dataset to seed them locally. Thanks for the reminder. -rex

On Wed, Feb 1, 2023 at 9:23 AM Kyle Ginzburg @.***> wrote:

Hey Rex, please revisit my above Issue. You still need to revisit your Features. On top of that, I don't expect you to use the Yelp API to pull data. Instead, we expect you to seed the data yourself.

So, for your four Main Features, we expect: Business Index/Show, Reviews/Ratings, Search, and the Google Maps API. Then Profile as a Bonus.

— Reply to this email directly, view it on GitHub https://github.com/junjiequ1459/fullstackProject/issues/2#issuecomment-1412144725, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANAJLT6LRF7RLHAN46LUS3DWVJWX3ANCNFSM6AAAAAAUKPGMHM . You are receiving this because you are subscribed to this thread.Message ID: @.***>