junjiequ1459 / MealMate

Yelp clone
5 stars 0 forks source link

Issue #03 - Schema #3

Open keginzburg opened 1 year ago

keginzburg commented 1 year ago

Database Schema

Comments

Hey Rex, just a few notes regarding your Schema:

  1. Right now, there's small formatting issues, but I trust you'll take care of these down the line as you've begun coding.
  2. Your Users and Business tables look pretty comprehensive. Lots of data to work with there. We briefly discussed this and what you could scale down, but overall excited to see how you display all of that data. One thing to note: maybe our Business names shouldn't be unique? There's always a small chance two businesses have the same franchise name, but their other information is different.
  3. Small note: your foreign key columns will be bigints, not ints.
  4. Also, the data type of your Review's body should not be textbox.
  5. For your last table, Favorite Reviews, I imagine this is just a joins table, but I was under the impression that Users could favorite Businesses, not Reviews. Also, this table is a bit sparse right now. Be sure to include timestamps.

Solid work here.