search

junjieteoh / pe

0 stars 0 forks source link

Object Diagram #17

Open junjieteoh opened 2 years ago

junjieteoh commented 2 years ago

image.png

From my understanding, this object diagram seems to be incorrect?

This seems to suggest that there is an Education object with variable name nus, rather than there is an Education object with the String value of = "nus"

If I am right, I think the correct version should be

: Education
value = "nus"

Similarly for Internship Module...

nus-pe-script commented 2 years ago

Team's Response

Reason for downgrading severity:
I believe the bug severity should be not be "Medium" but rather "VeryLow" or "Low" as this can be considered a cosmetic bug in the DG. It does not affect the usage of our application in any way.

I believe you are right, it should be like how you said it.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: image.png

I think it should not be very low because only cosmetic issues can have such label.

I think the criteria is a bit ambiguous in terms of whether it is low/medium. Arguably, nothing in the DG is going to affect normal operation/usage of your app, so I am not sure if Low is the upper bound for this type of bug.

I would still argue that it is a medium flaw because it completely changes the meaning of the diagram. Having a variable named nus and having an object with one of the field = "nus" can mean very different things and I would argue this might be misleading to fellow developers.

I will leave it for the teaching team to decide the severity but I will still argue that it is a Medium.