junjieteoh / pe

0 stars 0 forks source link

Restriction on modules/internship being only alphanumeric might be too restrictive #6

Open junjieteoh opened 2 years ago

junjieteoh commented 2 years ago

There might be modules that includes symbols. For eg "CS2103/T".

There might be company names that includes symbols. For eg "M&M".

Even though it is being specifically mentioned in UG that these values are not allowed, it will most likely cause trouble to users who is currently taking CS2103/T or having an internship at M&M.

I would rate it medium* because it can potentially affect many students.

There are many (thousands or tens of thousands) modules/companies in the world with symbols in their names. Having such restrictions may force users to work around this. For example, typing "M and M" instead of "M&M". This may not be ideal.

image.png

soc-se-bot commented 2 years ago

Team's Response

We believe that this should of low severity because it's a minor inconvenience but it does not prevent the user from recording information.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason] image.png

Sorry for doing this but I will attempt to justify the severity level. I am ignoring the module restriction and will be focusing on the internship one.

According to the guideline, it will be a low if the bug (Appears only in very rare situations and causes a minor inconvenience only). It is medium if it is "A flaw that causes occasional inconvenience to some users but they can continue to use the product."

I did a quick look-up/ search online and it is really not "rare" that company names contains symbols.

https://blog.designcrowd.com/article/744/100-famous-corporate-logos-from-the-top-companies-of-2015

Company names (original name) containing symbols out of the 100: Coca-Cola, McDonald’s, AT&T, Mercedes-Benz, L’Oreal, Frito-Lay, J.P. Morgan, H&M, T-Mobile, Lowe’s, Hewlett-Packard Enterprise, Kellogg’s. (which is 12%).

Of course, users can always opt to work around it (which is an inconvenience).

I defend medium severity because it seems to fit the description of

I will leave it for the teaching team to make the final call.