junjieteoh / pe

0 stars 0 forks source link

Error message not specific enough #8

Open junjieteoh opened 2 years ago

junjieteoh commented 2 years ago

When i key in the same command.

image.png

Expected message should be

Date and Time has to be valid!

which aligns with a invalid date input such as (2100-02-29).

image.png

Similarly for invalid time.

As users, it seems that I have followed the correct format (based on the error message) but my input is still being rejected.

nus-se-script commented 2 years ago

Team's Response

We believe the error messages are displaying and informing the user correctly about the correct and expected format to be given for the time/date input. For example, 'HH:mm' is universally understood that it's the representation of hours and minutes. We believe that explicitly mentioning the range of HOURS and MINUTES is unnecessary because one should be aware that minutes is within the range of 0 - 59. Similarly, it is impossible for the day of a month to be 33.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I guess it is fair to assume that

" For example, 'HH:mm' is universally understood that it's the representation of hours and minutes. We believe that explicitly mentioning the range of HOURS and MINUTES is unnecessary because one should be aware that minutes is within the range of 0 - 59. Similarly, it is impossible for the day of a month to be 33."

My concern is with the consistency of the error message. Explicitly saying the date/time is invalid may be a better choice IMO (because it instructs me to look into why the input is invalid date/time) as compared to saying it is an invalid format (which instructs user to look into how they type their params).

(As users, it seems that I have followed the correct format (based on the error message) but my input is still being rejected.)

Understand that this is a grey area (sorry about that), so I will let the teaching team make the final call.