Fix Windows not being able to delete temporary files

junkblocker / codesearch

Fork of Google codesearch with more options

BSD 3-Clause "New" or "Revised" License

46 stars 12 forks source link

Fix Windows not being able to delete temporary files #13

Closed makuto closed 2 years ago

makuto commented 2 years ago

Hi, The Windows version of codesearch is broken because it doesn't properly close any of its file handles before it tries to remove the files.

My fork has this change which fixes this. My fork has diverged (I added a tempDir argument so that I could move the temp files where I wanted them), but someone should be able to port over my changes without too much issue.

junkblocker commented 2 years ago

Thanks, @makuto! I'll take a look and port.

junkblocker commented 2 years ago

@makuto - Ported. I don't have a windows machine to test this on so if you could please let me know if this works for you, I'll close it.

junkblocker commented 2 years ago

Closing for releasing binaries. Please reopen if somebody sees an issue.