@Wire as convention

[DaanVanYperen]

@Wire has become convention. It enables one of the core selling points of ODB. For 1.0, perhaps its time to remove the requirement and add an inverse annotation instead.

• [x] default to @Wire for odb (and plugin managed, contrib M<Pos> example) types.
• [x] flip precedence of @SkipWire when @Wire becomes the default, right now Wire supersedes.

[nikoliazekter]

What do you mean by inverse annotation? Google doesn't give any results.

[antag99]

@nikoliazekter Something like an @Ignore annotation, that excludes a field/whole class.

[Namek]

@DoNOTWireArtemisHereOrIWillFeelBadAboutYou - this one would be pretty noticable.

[antag99]

Why not "@Namek"? (@Wire has suffered enough.)

[Namek]

Because :copyright:

[DaanVanYperen]

Are you suggesting @Namek is not wired? :P

[junkdog]

So, we'd still need @Wire for non-artemis types, but otherwise, everything is automatic? I'd like some perf profiling on android - if the hit isn't too big, let's go with it.

[DaanVanYperen]

Didn't consider the POJO case, it does make sense those will still require manual @Wire tag. If I remember correctly any custom injection handling goes before the POJO @Wire check so plugin devs are still able to define automatic injectables.

This is separate from #335 by the way, the PR doesn't change behavior of @Wire.

Maybe our local android adventurer @snorrees can reveal his thoughts about @Wire by convention. (and @SkipWire equivalent to skip it),.

[snorrees]

I think it will be fine. As long as the number of instances injected are in the amount of 10-100 there should be no problems. Its when you start doing injection for everything these things matter.

I can take this for a spin on my current codebase and report back later if you want? I still have systems with @Mapper annotations o_O, so I think I represent the legacy users.

Just to check: Having an @Wire annotation on a system is ignored in this setup right? I'm basically using "inherit=true" everywhere, so that part should be no problem.

[junkdog]

hehe, @Mapper will go away with 1.0.0

[snorrees]

Good ;)

[junkdog]

Hmm, i'll attend to this tomorrow.