junkdog / artemis-odb

A continuation of the popular Artemis ECS framework
BSD 2-Clause "Simplified" License
779 stars 112 forks source link

[Question] Archtype compositionId #569

Closed Mr00Anderson closed 5 years ago

Mr00Anderson commented 5 years ago

Is there any reason the Archetype.compositionId is package private?

https://github.com/junkdog/artemis-odb/blob/11111ba27794737e34bed3c10f96451d00d9e09b/artemis-core/artemis/src/main/java/com/artemis/Archetype.java#L12

I see that I can get an entities compositionId, which is why I would like to access the ArcheType compositionId. At initialization I will be mapping the ArcheType compositionId to a Entity Type name so that I can group my entities when displaying them by using the returned compositionId from the entity and looking it up.

DaanVanYperen commented 5 years ago

Exposed in https://github.com/junkdog/artemis-odb/commit/aa15f1eb3877ff0e21f169a935d19957287a6ca7

junkdog commented 5 years ago

👍

Converted tabs->spaces - maybe we should just do it for the entire project. Better now than later; it's already somewhat mixed.

On Fri, May 10, 2019, 8:21 PM Daan van Yperen notifications@github.com wrote:

Exposed in aa15f1e https://github.com/junkdog/artemis-odb/commit/aa15f1eb3877ff0e21f169a935d19957287a6ca7

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/junkdog/artemis-odb/issues/569#issuecomment-491385495, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGEJR6QI5I7ZDR36RCDX7LPUW4LNANCNFSM4HLUK4IA .