junkdog / artemis-odb

A continuation of the popular Artemis ECS framework
BSD 2-Clause "Simplified" License
779 stars 113 forks source link

[BUG] GitHub not accepting/identifying the LICENSE (as BSD-2-clause) #601

Closed hoijui closed 3 years ago

hoijui commented 4 years ago

(old, closed, but same issue: https://github.com/junkdog/artemis-odb/issues/464)

While GitHub detects LICENSE (BSD-2-clause) as the main LICENSE file, it apparently also sees LICENSE.libgdx (APLv2), and thus it decides to not know what the license is; compare these two:

NOTE: I checked on my fork: If I remove the LICENSE.libgdx file, GitHub detects BSD-2-clause; see: https://github.com/hoijui/artemis-odb/blob/develop/LICENSE

hoijui commented 4 years ago

GitHub recommends to have only one LICNESE file with one license in it, and talk about the other license related stuff (like licenses of dependencies or secondary licenses) in the README:

https://help.github.com/en/github/creating-cloning-and-archiving-repositories/licensing-a-repository#detecting-a-license

hoijui commented 4 years ago

(side comment; quite unrelated)

maybe also put this in the README?

License

[![License](https://img.shields.io/badge/License-BSD%202--Clause-orange.svg)](https://opensource.org/licenses/BSD-2-Clause)

hoijui commented 4 years ago

I found a related stack* question. the first two answers seem very good: https://softwareengineering.stackexchange.com/questions/304874/declaring-multiple-licences-in-a-github-project/371526

junkdog commented 4 years ago

thanks for the head's up and info! i'll fix it after work/sometime this week.

DaanVanYperen commented 3 years ago

Thanks @hoijui! :cookie: That was an absolute pain to fix but it works.