search

junkdog / entity-system-benchmarks

microbenchmarks comparing ECS (entity component system) frameworks for java
Apache License 2.0
35 stars 8 forks source link

Ashley 1.2.0 Insert/remove benchmarks #9

Closed DaanVanYperen closed 9 years ago

DaanVanYperen commented 9 years ago

What's going on with the Ashley 1.2.0 insert/remove benchmarks? I'm assuming this is a benchmark bug?

junkdog commented 9 years ago

Error in the benchmark, so i excluded it consider the release is defunct anyway.

On Thu, Sep 25, 2014 at 10:00 AM, Daan van Yperen notifications@github.com wrote:

What's going on with the Ashley insert/remove benchmarks? I'm assuming this is a benchmark bug?

https://camo.githubusercontent.com/532b20f1f40fd755109d710d2250f4e64d627991/687474703a2f2f6a756e6b646f672e6769746875622e696f2f696d616765732f6563732d62656e63682f696e736572745f72656d6f76652d36353533362e706e67

https://camo.githubusercontent.com/560a3ba7df92d298af59d544535f8227b0e59f86/687474703a2f2f6a756e6b646f672e6769746875622e696f2f696d616765732f6563732d62656e63682f696e736572745f72656d6f76652d313032342e706e67

— Reply to this email directly or view it on GitHub https://github.com/junkdog/entity-system-benchmarks/issues/9.

DaanVanYperen commented 9 years ago

Hmmm maybe replace the benchmark images on the main artemis-odb README.md for one without Ashley 1.2.0, it's unintentionally disingenuous now. I'll add a quick notice to the readme.

junkdog commented 9 years ago

Ah, now - I misread you (didn't get any sleep last night) - the ashley 1.0.1 pooling tests were off. The insert/remove performance degradation in 1.0.1 vs 1.2.0 comes from changing from an IntMap to Array. I tweeted siondream about it though, asking if the test was conforming intended ashley usage. Haven't heard back from him yet.

On Thu, Sep 25, 2014 at 10:12 AM, Daan van Yperen notifications@github.com wrote:

Hmmm maybe replace the benchmark images on the main artemis-odb README.md for one without Ashley 1.2.0, it's unintentionally disingenuous now. I'll add a quick notice to the readme.

— Reply to this email directly or view it on GitHub https://github.com/junkdog/entity-system-benchmarks/issues/9#issuecomment-56787269 .

junkdog commented 9 years ago

The bar is there, it just starts out really low - 72.88 at 1024 entiteis, goes down to 1.05 at 65k entities.

DaanVanYperen commented 9 years ago

Ugh! Would be nice to help them fix it. You don't seem to sleep anymore anyway!

junkdog commented 9 years ago

Yup, definitely something that should be improved. If you're up for it, have a look at the benchmark code - just to make sure i haven't done anything stupid.

DaanVanYperen commented 9 years ago

Profiling probably beats proofreading code like this. ;)