unit=time: wrong data displayed

[ildar170975]

Consider this example:

type: entities
entities:
  - entity: input_number.test_negative_1
    name: standard
  - type: custom:numberbox-card
    entity: input_number.test_negative_1
    name: unit=time (with ss)
    unit: time
  - type: custom:numberbox-card
    entity: input_number.test_negative_1
    name: unit=timehm
    unit: timehm

  test_negative_1: &ref_test_nagative_values
    min: -10000000
    max: 10000000
    step: 0.1
    mode: box

Output is:

1. A value for "seconds" is wrong - it must be "4.4".
2. Imho the "seconds" value should be rounded.

[ildar170975]

t += ':' + Math.floor(x%60).toString().padStart(2,'0');

Can we have a rounding here instead of just "floor"?

[htmltiger]

rounding of 59.6 would display 60 would be confusing

[ildar170975]

From another side, conversion from float to hh:mm:ss should be mathematically as precise as possible ...

[htmltiger]

this would be ok

    x=Math.round(x);
    t = (x>=3600 || f)? Math.floor(x/3600).toString().padStart(2,'0') + ':' : '';
    t += (Math.floor(x/60)-Math.floor(x/3600)*60).toString().padStart(2,'0');
    if( !u ){
        t += ':' + Math.round(x%60).toString().padStart(2,'0');
    }
    return t;

[ildar170975]

Cannot verify it quickly, unfortunately, I am about C/C++ basically, know JS worse ((((

[htmltiger]

we round it first before processing so 59.6 would become 60 so will display as 01:00

[ildar170975]

Very good! I will try to test all these cases when you create the updated release.

[ildar170975]

Tested, seems to be OK! Thank you!