search

junlarsen / RiotQuest

[Deprecated] PHP 7.1+ Library for the Riot Games API
MIT License
8 stars 3 forks source link

"ERROR (code 3): Internal Service Error. Please report this error by opening an issue on GitHub." #44

Closed WildEgo closed 5 years ago

WildEgo commented 5 years ago

Describe the bug I really don't have a good explanation the request is just not created I'd suppose

To Reproduce Steps to reproduce the behavior:

  1. use RiotQuest\Client as LeagueAPI;
  2. return LeagueAPI::summoner(strtolower($result->server))->name($result->account_ign);
  3. "ERROR (code 3): Internal Service Error. Please report this error by opening an issue on GitHub."

Expected behavior Should've returned anything that is not an error

Desktop (please complete the following information):

Additional context Should be manifest.json related

junlarsen commented 5 years ago

It looks like something has been changed on the API. I'll investigate the issue and publish a fix.

WildEgo commented 5 years ago

It looks like something has been changed on the API. I'll investigate the issue and publish a fix.

really appreciate it man good job on the package, keep us updated

junlarsen commented 5 years ago

The issue should be resolved now. If you bump into it again open another issue and I'll have another look.

I believe the cause was that the Riot API's Shard status response object had changed. It now has a heading inside MessageDTO which was not documented on the Riot API site.

I have released the patch under the tag 1.3.1.