search

junlarsen / league-connect

:electric_plug: Node.js HTTP/1.1, HTTP/2.0 and WebSocket interface to the League of Legends Client APIs
https://www.npmjs.com/package/league-connect
MIT License
156 stars 24 forks source link

LeagueClient doesn't emit connect/disconnect any more after one detection of disconnection #40

Closed zhaoyeming closed 3 years ago

zhaoyeming commented 3 years ago

A quick look at source code reveals that an onTick() call should probably be invoked again after emitting 'connect'

junlarsen commented 3 years ago

If you're thinking about adding a call to onTick here you're probably right. https://github.com/supergrecko/league-connect/blob/master/src/client.ts#L83

I'll look into it, verify and ship a new patch later today.

junlarsen commented 3 years ago

Solved and fixed in https://github.com/supergrecko/league-connect/commit/7d009f8e17088f12d122aa64635c38a985953a83

Tagged release 5.0.2. Thank you for reporting!