search

junneyang / zumastor

Automatically exported from code.google.com/p/zumastor
0 stars 1 forks source link

/proc/driver/ddsnap needs namespacing #126

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Create more than one volume with zumastor
2. Try and see the number of inflight bio reqs buy looking in
/proc/driver/ddsnap
3. Observe collisions (-1)

What is the expected output? What do you see instead?
One 'file' per name, instead you see

root@zuma:/proc/driver/ddsnap# ls -l
total 0
-r--r--r-- 1 root root 0 May  1 09:09 -1
-r--r--r-- 1 root root 0 May  1 09:09 -1
-r--r--r-- 1 root root 0 May  1 09:09 1009
-r--r--r-- 1 root root 0 May  1 09:09 1014
-r--r--r-- 1 root root 0 May  1 09:09 1015

What version of the product are you using? On what operating system?
root@zuma:/proc/driver/ddsnap# zumastor --version
zumastor v0.8.0 revision 1598 built on Sat Apr 26 18:12:52 PDT 2008 by
willn@zuma
root@zuma:/proc/driver/ddsnap# ddsnap --version
ddsnap revision 1598 built on Sat Apr 26 18:12:59 PDT 2008 by willn@zuma

Original issue reported on code.google.com by compbr...@gmail.com on 1 May 2008 at 4:12

GoogleCodeExporter commented 9 years ago 
I will take it.

Original comment by jiahotc...@gmail.com on 1 May 2008 at 4:30

GoogleCodeExporter commented 9 years ago 
added cbtb/tests/1/ddsnap-kernel-namespace.sh in r1649

Original comment by compbr...@gmail.com on 7 May 2008 at 11:49

GoogleCodeExporter commented 9 years ago 
Here is the proposed patch to fix the problem. It uses the device name as the 
proc
entry name, which is unique even with multiple ddsnap volumes. However, lvm 
allows
users to rename a device after it is created. The patch does not deal with that 
case
yet. There is also collisions with the ddsnap kernel threads if there are 
multiple
volumes. We may want to enter an issue for solving that collision and the 
renaming case.

Jiaying

Original comment by jiayin...@gmail.com on 22 May 2008 at 12:11

Attachments:

GoogleCodeExporter commented 9 years ago 
lgtm, worked with uml.

Original comment by williama...@gmail.com on 23 May 2008 at 6:12

GoogleCodeExporter commented 9 years ago 
What's the status of this patch?

Original comment by daniel.r...@gmail.com on 28 May 2008 at 1:40

GoogleCodeExporter commented 9 years ago 
Fixed by revision 1672. The patch to be reviewed later.

Original comment by jiahotc...@gmail.com on 28 May 2008 at 7:14