An error in ddsnap manpage on the '--cachesize' option

[GoogleCodeExporter]

The '--cachesize' option is listed as an option of 'ddsnap initialize'. It
is actually an option passed to 'ddsnap server' and can be changed after
the volume is defined. Here is the fix.

Index: man/ddsnap.8
===================================================================
--- man/ddsnap.8        (revision 1652)
+++ man/ddsnap.8        (working copy)
@@ -8,13 +8,13 @@
 [\-V|--version] [-?|--help] [--usage] \fIsubcommand\fP [option\.\.\.]
[operand...]
 .br
 .B ddsnap initialize
-[\-y|--yes] [-j|--journalsize \fIjournalsize\fP] [-b|--blocksize
\fIblocksize\fP] [-c|--chunksize \fIchunksize\fP] [-k|--cachesize
\fIcachesize\fP] \fIsnapshot_device\fP \fIorigin_device\fP [\fImeta_device\fP]
+[\-y|--yes] [-j|--journalsize \fIjournalsize\fP] [-b|--blocksize
\fIblocksize\fP] [-c|--chunksize \fIchunksize\fP] \fIsnapshot_device\fP
\fIorigin_device\fP [\fImeta_device\fP]
 .br
 .B ddsnap agent
 [\-f|--foreground] [-l|--logfile \fIfile_name\fP] [-p|--pidfile
\fIfile_name\fP] \fIagent_socket\fP
 .br
 .B ddsnap server
-[\-f|--foreground] [-l|--logfile \fIfile_name\fP] [-p|--pidfile
\fIfile_name\fP] \fIsnapshot_device\fP \fIorigin_device\fP [\fIdev/meta\fP]
\fIagent_socket\fP \fIserver_socket\fP
+[\-f|--foreground] [-l|--logfile \fIfile_name\fP] [-p|--pidfile
\fIfile_name\fP] [-k|--cachesize \fIcachesize\fP] \fIsnapshot_device\fP
\fIorigin_device\fP [\fIdev/meta\fP] \fIagent_socket\fP \fIserver_socket\fP
 .br
 .B ddsnap create
 .I server_socket snapshot
@@ -130,7 +130,7 @@
 .br
 Starts the snapshot agent.
 .IP \fBserver
-[\-f|--foreground] [-l|--logfile \fIfile_name\fP] [-p|--pidfile
\fIfile_name\fP]
+[\-f|--foreground] [-l|--logfile \fIfile_name\fP] [-p|--pidfile
\fIfile_name\fP] [-k|--cachesize \fIcachesize\fP]
 .I snapshot_device origin_device
 [\fIdev/meta\fP]
 .I agent_socket server_socket

Willn or dank, could you review the patch?

Jiaying

Original issue reported on code.google.com by jiahotc...@gmail.com on 9 May 2008 at 6:51

[GoogleCodeExporter]

Patch attached.

Original comment by jiahotc...@gmail.com on 9 May 2008 at 7:05

• Added labels: ****
• Removed labels: ****

Attachments:

• ddsnap_manpage.patch

[GoogleCodeExporter]

Copy in LGTM from shapor on Fri, May 9, 2008 at 12:15 PM
Also LGTM from me.

Original comment by williama...@gmail.com on 12 May 2008 at 5:41

• Added labels: ****
• Removed labels: ****

[GoogleCodeExporter]

Fixed with revision 1657.

Original comment by jiahotc...@gmail.com on 12 May 2008 at 8:52

• Changed state: Fixed
• Added labels: ****
• Removed labels: ****