junneyang / zumastor

Automatically exported from code.google.com/p/zumastor
0 stars 1 forks source link

Kernel module should use socket API #141

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The file 
http://code.google.com/p/zumastor/source/browse/trunk/ddsnap/kernel/dm-ddsnap.c
would be easier to read if it used the 
in-kernel sockets API that's been in the 
kernel for over a year now. See
http://lwn.net/Articles/194500/ and
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=ac5a
488ef252ed673cb067843e411f8cc43f7ab9

Original issue reported on code.google.com by daniel.r...@gmail.com on 16 May 2008 at 5:34

GoogleCodeExporter commented 9 years ago
Looks like there's only one use of the old "API."  Patch attached.

Original comment by vand...@gmail.com on 28 May 2008 at 5:28

Attachments:

GoogleCodeExporter commented 9 years ago
Could you also try to use kernel_senmsg and kernel_recvmsg in readpipe() and 
writepipe()?

Jiaying

Original comment by jiayin...@gmail.com on 28 May 2008 at 6:14

GoogleCodeExporter commented 9 years ago
I converted the use of files to sockets.

After fighting with CBTB UML for a while...  This passes all the CBTB tests that
passed in Rev 1673 and are not expected to fail.

Original comment by vand...@gmail.com on 3 Jun 2008 at 8:51

Attachments:

GoogleCodeExporter commented 9 years ago
Resolved with commit 1703

Original comment by vand...@gmail.com on 10 Jun 2008 at 1:03