search

junneyang / zumastor

Automatically exported from code.google.com/p/zumastor
0 stars 1 forks source link

Make sure 'bash', not 'sh', is always required #63

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
/bin/sh is not always 'bash'

The attached patch against trunk fixes that in run_remote in /bin/zumastor

Original issue reported on code.google.com by pgqui...@gmail.com on 9 Feb 2008 at 10:43

Attachments:

GoogleCodeExporter commented 9 years ago 
This seems to fix the failing 'bashisms.sh' test, as Ubuntu was installing dash:

[...]
+ aptitude install -y dash
[...]
The following NEW packages will be installed:
 dash
[...]
Get:1 http://172.23.32.1 dapper/main dash 0.5.3-1ubuntu1 [83.8kB]
[...]
+ for f in /bin/zumastor /etc/cron.hourly/zumastor /etc/init.d/zumastor
/etc/cron.weekly/zumastor /etc/cron.daily/zumastor
+ sed -i 's:^#!/bin/bash:#!/bin/sh:' /bin/zumastor
[...]
+ zumastor define volume testvol /dev/sdb /dev/sdc --initialize
/lib/zumastor/common: 7: declare: not found
/lib/zumastor/common: 8: declare: not found
/lib/zumastor/common: 9: declare: not found
[...]

update-alternatives --install /bin/sh sh /bin/dash 1

Original comment by pgqui...@gmail.com on 9 Feb 2008 at 10:54

GoogleCodeExporter commented 9 years ago 
This also needs fixing in zumastor/debian/control: bash must be explicitly 
required

Original comment by pgqui...@gmail.com on 9 Feb 2008 at 10:55

Attachments:

GoogleCodeExporter commented 9 years ago 
The patches attached to #1 and #2 above look good.
Will, go ahead and apply...

The comment in #1 seems confused - we expect the
bashisms.sh test to continue to fail until
we port our scripts to posix sh, which is unlikely
to happen any time soon (we have a Bash partisan
aboard who feels that using /bin/test's = to compare
strings is satanic).

Original comment by daniel.r...@gmail.com on 13 Feb 2008 at 1:04

GoogleCodeExporter commented 9 years ago

Original comment by williama...@gmail.com on 13 Feb 2008 at 1:06