Closed GoogleCodeExporter closed 9 years ago
Original comment by daniel.r...@gmail.com
on 26 Mar 2008 at 6:12
The patch looks good for switching to O_DIRECT, but shouldn't we just use
fadvise
instead if our only goal is preventing us from trashing the page cache? We'd
have to
call posix_fadvise(POSIX_FADV_DONTNEED) for every range we read in each
iteration of
the loop to evict the pages, because sadly Linux doesn't remember the setting
for
future file operations.
Original comment by sha...@gmail.com
on 1 Apr 2008 at 10:28
Yes. We can just use posix_fadvise for this. O_DIRECT and posix_fadvise seem to
have
the same performance results according to my measurement. Thanks for your
suggestion.
In the attachment is the updated patch.
Original comment by jiayin...@gmail.com
on 5 Apr 2008 at 1:10
Attachments:
Looks good to me.
Original comment by sha...@gmail.com
on 5 Apr 2008 at 1:17
Fixed with revision 1525.
Original comment by jiahotc...@gmail.com
on 8 Apr 2008 at 1:12
Original issue reported on code.google.com by
jiayin...@gmail.com
on 25 Mar 2008 at 10:41