Closed skeleturtle closed 3 months ago
Looking into it
Switching assignment to @oneBlueFish since he is working on doing away with the auto generated code.
I have updated jfx-luna
off of the auto generated services, this should help with this issue
There is just a little clean up i would like to do
@skeleturtle , if you would like to try the code out, pull down the removing_auto_code
branch on jfx-luna
All the pytests passed, so you shouldn't run into any issues, but if you do, let me know :)
I have updated
jfx-luna
off of the auto generated services, this should help with this issueThere is just a little clean up i would like to do
@skeleturtle , if you would like to try the code out, pull down the
removing_auto_code
branch onjfx-luna
All the pytests passed, so you shouldn't run into any issues, but if you do, let me know :)
Getting errors
Example issues:
Things that appear to be working:
@oneBlueFish do you need my help on this one?
@oneBlueFish
Adding some of what we talked about on discord here for visibility.
I pushed another update to my branch. We ran into the junoFiles file_type issue again. What I noticed was the JunoF jfx-luna class was the only one that wasn't using the the rawOutData from our models. It was inheriting our in junoFile model. This is what was causing the descrepencies when casting our outJunoFile into a JunoFile class, and us trying to work around.
I have also noticed a descrepency with our file types from previous luna iterations. I adjusted the 1 script I had to account for it , but can easily adjust it back. when we get a task, and then get our outMeta from task.publishes/task.deliveries/task.work they are all returned as a dictionary. Which based on my previous code was always the case, but when I would get the file_type from those dictionaries, it would have been returning the FileType enum, where as now its a dictionary of that enum. I'm not sure how big of a deal this is, I simply adjusted the code in the one instance where I saw it happening.
Marking as complete.
Jfx-luna is being released. We can discuss next steps for getting things more consistent.
We are getting hit once again with that error with the 'value_'