search

junqiangchen / LiTS---Liver-Tumor-Segmentation-Challenge

LiTS - Liver Tumor Segmentation Challenge
MIT License
234 stars 73 forks source link

Performance issue in /LiTS/data_input (by P3) #30

Closed DLPerf closed 2 years ago

DLPerf commented 3 years ago

Hello! I've found a performance issue in dataset_input.py: dataset.batch(batch_size)(line 109) should be called before dataset.map(_parse_function)(line 107) and dataset.map(_preprocess_function)(line 108), which could make your program more efficient.

Here is the tensorflow document to support it.

Besides, you need to check the function _preprocess_function called in dataset.map(_preprocess_function) whether to be affected or not to make the changed code work properly. For example, if _preprocess_function needs data with shape (x, y, z) as its input before fix, it would require data with shape (batch_size, x, y, z) after fix.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

DLPerf commented 2 years ago

Hello, I'm looking forward to your reply~

junqiangchen commented 2 years ago

Hello, I'm looking forward to your reply~

thank you for your suggestion，i have converted tf code to pytorch，and using pytorch dataset load the dataset，you can find the pytorch project from here:https://github.com/junqiangchen/PytorchDeepLearing