Closed chianwei closed 6 years ago
Of course! Delighted of receive changes!
Just one thing: I've never used multithread with make
, but it seems that 48 are a lot of threads. Does it matter or the os manages it ok?
Thank you junquera! This is my first pull request :smile:
Compiling using make
command with number of jobs (-j) flag can reduce the amount of compilation time. I have a 24 threads machine so I set to two times of threads available(I don't know how to make it be a variable that changes with various machine :disappointed:), but actually, nDPI and ntopng source codes are not much like Linux Kernel, the reduction of compilation time between added and without -j flag is not significant. :smiley:
Perfect! Thanks! I'll merge and upload it to the docker cloud too.
Hi junquera! I added some comments to your docker file that are useful for new docker users(like me) to understand it 😃
And also I update the git link of nDPI and ntopng to newer version. At time I build this docker container, the version I used are: nDPI: branch-2.2-stable ntopng: v.3.2.180207
Please consider to confirm my pull request 😄 Thank you!