search

junrrein / pdfslicer

A simple application to extract, merge, rotate and reorder pages of PDF documents
https://junrrein.github.io/pdfslicer/
GNU General Public License v3.0
149 stars 18 forks source link

Wrong icon to show page #170

Open Vanadiae opened 4 years ago

Vanadiae commented 4 years ago

Currently when passing the mouse on a page, the button to show the entire page is a magnifying glass like this :

Magnifying glass

However, this icon is to represent a search feature. So I propose to change this icon to more obvious one, like view-fullscreen-symbolic :

view-fullscreen-symbolic

This is a quite easy thing to change though.

junrrein commented 4 years ago

Hi there!

I agree that the current icon for the "Big preview" button does not fit too well. But then, I don't think that view-fullscreen-symbolic is a better metaphor either. This icon was actually changed in the past, see this.

Is there any prior art on this? Are there another applications we could use as an example?

Vanadiae commented 4 years ago

Well, Eye of GNOME and Pitivi do use an icon for those kind of tasks but it's not a symbolic one and mixes pretty horribly with the symbolics one :

icon_symbolics (on the right)

In Icon Library (where I looked for icons), I can see some others that could fit : eye-open-symbolic, detach-symbolic, view-dual-symbolic, view-paged-symbolic, emblem-documents-symbolic, x-office-document-symbolic and rather unlikely but still text-x-generic-symbolic, step-in-symbolic, view-restore-symbolic. I let you copy-paste these titles in the search bar to see how it looks like. (you can still look at all the icons on the main page if you'd like if nothing suits you). When you have decided of the most suitable one, I can try to make the related PR since it's just a simple text to change.

junrrein commented 4 years ago

Reading through this issue again, I noticed something: we think about this feature in different terms. I think it's "show this, but bigger", while you think about it as "show the entire page".

In my metaphor, using a magnifying glass icon makes sense, since you use that tool to make things bigger to the sight. But in your metaphor, the icon is completely wrong.

I guess we should first settle on what terms to use when talking about this feature. I'm quite convinced about my take, but I'm open to be convinced to think about it differently.

Sorry if all of this back-and-forth seems like a waste of time.

PS: Thanks for mentioning the Icon Library app, it's really helpful. I took a look at all of the options you mentioned, but I'm saving my commentary until we decide on the other stuff.

Vanadiae commented 4 years ago

Humm... when I say "show the entire page", I mean that rather than having multiple small-view pages, we can see a specific page more bigger, so "show this, but bigger" if you prefer this wording. I opened this issue because while the "magnifying glass" is a suitable metaphor to represent this, it is used everywhere to represent a "search feature" and so I find it confusing (I first thought it was a search feature). So thinking through this, the only one that could fit in the previous list is probably eye-open-symbolic.