search

junrrein / pdfslicer

A simple application to extract, merge, rotate and reorder pages of PDF documents
https://junrrein.github.io/pdfslicer/
GNU General Public License v3.0
150 stars 18 forks source link

Double click to show page preview #172

Open amivaleo opened 4 years ago

amivaleo commented 4 years ago

Hi!

Each page loaded in Slicer has a hidden "preview" button which appears on hovering.

Since hovering is not possible on touch devices, can you please consider to allow to trigger that very same action by double-clicking on the page thumbnail?

I believe it might come in handy also for the traditional mouse&keyboard UX since the thumbnail offers a larger area for interaction than the hidden button. Also, it might be slightly quicker maybe.

⚠: the double-click should not toggle the page selection.

junrrein commented 4 years ago

Hi there! I completely agree with your reasoning, on all items. This should get done.

Thanks for the report!

Vanadiae commented 4 years ago

It is not a very discoverable behavior as described under General guidelines. It would be rather more logical to just always show this preview button.

amivaleo commented 4 years ago

It is not a very discoverable behavior as described under General guidelines. It would be rather more logical to just always show this preview button.

Yes, I'm aware of that. Me and Julian talked already about this "preview window" and how to make it available in the UI to touch devices (here: https://github.com/junrrein/pdfslicer/issues/30#issuecomment-489116521 ). I actually tried to convince him to get rid of that entirely. As you can see, I failed. 😄

So yes, the UI for this action is still a open issue. Please, if you have any suggestion, simply tell us. I can't figure this one out.

junrrein commented 4 years ago

@Vanadiae You make a good point, and I'm aware of that issue. And @amivaleo is right with the history lol.

I've created #179 so we have a separate place to talk about it.