junseonghwan / PhylEx

3 stars 1 forks source link

dropout probability is replaced by fixed value of 0.5 #20

Open toyo97 opened 3 years ago

toyo97 commented 3 years ago

At this line, the dropout probability delta0 is set as 0.5 instead of the value specified in the configuration file simul_config.dropout_rate https://github.com/junseonghwan/PhylEx/blob/80e639c59952741a047cd3cce08b340445644c71/simulation/simul_data.cpp#L105

A similar issue is found here, where the two methods actually do the same thing. The random one isn't actually random https://github.com/junseonghwan/PhylEx/blob/80e639c59952741a047cd3cce08b340445644c71/src/clone_node.cpp#L39-L54