search

junsikshim / react-pane-system

A declarative, flexible pane layout system for React projects.
MIT License
6 stars 1 forks source link

Separate splitters into a layer. #20

Closed junsikshim closed 6 months ago

junsikshim commented 6 months ago

Related issue: #11

I've separated splitters into a new layer(SplitterLayer), and it's on the same level as PaneRows. Splitters are managed in SplitterRegistry, and all the splitter-related files are located in splitter directory.

SplitterIntersectionHandle is a square div which acts as a handle to move two splitters at the same time. There is a bug in which horizontal splitter's width does not keep up with the pointer movement. Let's move that into a separate issue.

Also, I've refactored PaneSystem and PaneRow to reduce the number of unnecessary props. (There still exist unused props though)

junsikshim commented 6 months ago

I think this PR is ready with the exception of the bug mentioned above. Please review this! @hchangjae

hchangjae commented 6 months ago

Awesome!

hchangjae commented 6 months ago

https://github.com/junsikshim/react-pane-system/assets/52942171/3ff4f402-d6c0-490b-a683-39cd01b3dbae

The bug mentioned above refers to this, right? I also think it might be better to address this as a separate issue.

junsikshim commented 6 months ago

The bug mentioned above refers to this, right? I also think it might be better to address this as a separate issue.

Yeah, I'll merge this, and create a new issue regarding the bug.