juntagrico / juntagrico-billing

GNU Lesser General Public License v3.0
3 stars 2 forks source link

BILL_EMAILS config is ignored #23

Closed pascalfree closed 8 months ago

pascalfree commented 1 year ago

The BILL_EMAILS setting is not used anywhere. I would remove it

Note: The main Juntagrico app will remove the EMAILS setting in release 2.0.0. Instead all templates will be namespaced and overriding can happen with the method described here: https://docs.djangoproject.com/en/4.0/howto/overriding-templates/

As this overriding already works at the moment, I would rather document that, instead of fixing the BILL_EMAILS setting.

samuel-iseli commented 1 year ago

don't really know where BILL_EMAILS comes from, never used it in the billing project. Will remove it.

samuel-iseli commented 8 months ago

Yes we should remove this setting. Is already part of issue #7 . Closing this issue as duplicate