search

juntossomosmais / atomium

Atomium is an internal design system for 'Juntos Somos Mais' using Web Components
https://juntossomosmais.github.io/atomium/
MIT License
169 stars 6 forks source link

[Fix] Modal workaround #535

Open matheus-rosa-jsm opened 3 months ago

matheus-rosa-jsm commented 3 months ago

The problem

In the version 7.0 of ionic ion-modal has an undesired behavion on backdrop. It block body scrolling. Inonic issue: https://github.com/ionic-team/ionic-framework/issues/23942 This issue was resolved in the new ionic maijor version, 8.0

What is needed

To avoid this behavior was created an workaround and it will be no longer needed after the ionic upgrade. So is necessary remove it.

PR with the workaround: https://github.com/juntossomosmais/atomium/pull/534

It's necessary remove all manual interaction with backdrop-no-scroll class: document.body.classList.remove(BACKDROP_NO_SCROLL)

tassioFront commented 1 month ago

We needed to improve the workaround as more issues were happening. The last adjustments are found here.