juntossomosmais / atomium

Atomium is an internal design system for 'Juntos Somos Mais' using Web Components
https://juntossomosmais.github.io/atomium/
MIT License
168 stars 6 forks source link

feat(select): add validation in select tag #590

Closed Natalie9 closed 2 weeks ago

Natalie9 commented 4 weeks ago

Infos

Task

What is being delivered?

Adds a validation when the element to attach the tag to is not found in the select options.

What impacts?

Select component

Reversal plan

Rollback this PR

Evidences

Sentry triggered some errors related to this code snippet and with potential navigation crash. These errors were not reproducible because they occur on specific devices. However, to work around the problem and prevent navigation crashes, the changes in this PR were made.

There were no visual changes. The change occurs if there is any issue when searching for the element to attach the tag and it is not found, return to the view without adding the tag.

github-actions[bot] commented 4 weeks ago

PR Preview Action v1.4.8 :---: Preview removed because the pull request was closed. 2024-10-21 11:30 UTC

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed for 'juntossomosmais_atomium_core'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
62.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud