juntossomosmais / atomium

Atomium is an internal design system for 'Juntos Somos Mais' using Web Components
https://juntossomosmais.github.io/atomium/
MIT License
169 stars 6 forks source link

fix(input): dont remove eventlistener on blur/focus #598

Closed igorwessel closed 3 weeks ago

igorwessel commented 1 month ago

Infos

Task

What is being delivered?

As we are removing the event listener in the "handleBlur" and "handleFocus" methods, libraries that use these events cannot function correctly after the first activation because we remove the event listener.

What impacts?

Reversal plan

Evidences

With fix:

https://github.com/user-attachments/assets/58e97702-5d29-4eb2-a299-0fc6ddd0c960

Without fix, current production branch:

https://github.com/user-attachments/assets/f6b5200b-66f0-495a-9a3f-d917bf776281

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed for 'juntossomosmais_atomium_core'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 1 month ago

PR Preview Action v1.4.8 :---: Preview removed because the pull request was closed. 2024-10-31 14:17 UTC