search

junxy / elmah

Automatically exported from code.google.com/p/elmah
Apache License 2.0
0 stars 0 forks source link

Fix build issues with the demo project #387

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
Purpose of code changes on this branch:

Fix issues 382 and 384

When reviewing my code changes, please focus on:

https://code.google.com/r/jamesdriscoll71-demo-project-issues

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by jamesdriscoll71 on 10 Mar 2015 at 12:04

GoogleCodeExporter commented 8 years ago 
Subject: revision 1c036c80b7d0)

I'm not in favour of changing the project type just because NuGet does not 
support Web Site projects. May be NuGet needs to be fixed!

The Demo web site is meant to be a simple sample and a Web Site project 
maintains that simplicity.

That all said, I'm surprise that Web Site projects are not supported. Towards 
the end of section “Automatic Package Restore in Visual Studio”[1] of the 
“NuGet Package Restore” documentation, it says clearly that one of the 
advantages of the new system is “Compatibility with ASP.NET Web Site projects 
created in Visual Studio.” Is that only when restoring from within VS as 
opposed to the command line?

If Web Site projects are not supported, I would resort to the old working 
approach of prestore.cmd but giving the packages.config path explicitly to 
`nuget restore` instead of letting it guess. For example, this can be achieved 
with the single command line of (assuming a current directory of the solution 
root):

for /f %p in ('dir packages.config /s/b ^| findstr /v /i PrecompiledWeb') do 
@nuget restore -PackagesDirectory .\packages %p

It doesn't matter whether we approach that through nugetRestore.proj or a batch.

[1] 
https://docs.nuget.org/consume/package-restore#user-content-automatic-package-re
store-in-visual-studio

Original comment by azizatif on 10 Mar 2015 at 6:19

GoogleCodeExporter commented 8 years ago

Original comment by azizatif on 10 Mar 2015 at 6:19

GoogleCodeExporter commented 8 years ago 
This issue has been migrated to:
https://github.com/elmah/Elmah/issues/387
The conversation continues there.
DO NOT post any further comments to the issue tracker on Google Code as it is 
shutting down.
You can also just subscribe to the issue on GitHub to receive notifications of 
any further development.

Original comment by azizatif on 25 Aug 2015 at 8:27