search

junyanz / interactive-deep-colorization

Deep learning software for colorizing black and white images with a few clicks.
https://richzhang.github.io/ideepcolor/
MIT License
2.69k stars 447 forks source link

Windows installation #72

Closed mabdelhack closed 4 years ago

mabdelhack commented 4 years ago

Updated code for python 3 and readme to reflect windows installation. I think this should either be appended to the code and readme or added as a new branch.

junyanz commented 4 years ago

Looks great. It might be better to be in a different branch. Not sure how these changes will affect Ubuntu users.

junyanz commented 4 years ago

I just created a windows branch. Could you change your target branch?

mabdelhack commented 4 years ago

Done, thanks for creating the new branch.

junyanz commented 4 years ago

Thanks for your contribution. Merged.

junyanz commented 4 years ago

I am wondering if your guide works for Caffe backend as well. You mentioned that "...a windows installation guide for the PyTorch model in Python 3.6...". But there is still some information about the Caffe model in the windows branch README.

mabdelhack commented 4 years ago

I see, I think I missed some parts about Caffe. I did not test the Caffe model because in my experience, installing it on Windows was a painful process. I'll revise again.

junyanz commented 4 years ago

Got it. Thanks.