search

junyanz / pytorch-CycleGAN-and-pix2pix

Image-to-Image Translation in PyTorch
Other
22.74k stars 6.29k forks source link

Is modify_commandline_options ever called? #514

Closed Roulbac closed 5 years ago

Roulbac commented 5 years ago

I get the idea of letting models setting the defaults that are specific to them; like the cyclegan using lsgan by default or the pix2pix using vanilla gan by default; but is the modify_commandline_options ever called? I did a quick search through the repo for 'modify_commandline_options' and didn't find a single call. Is this a bug?

junyanz commented 5 years ago

It is called here. get_option_setter will return a function object modify_commandline_options.