search

junyechen1996 / draft-chen-cfrg-vdaf-pine

VDAF to support aggregating real number vectors with L2-norm bound
Other
4 stars 0 forks source link

Conflicting definitions of `encoded_gradient` #65

Closed junyechen1996 closed 6 months ago

junyechen1996 commented 6 months ago

We currently return encoded_gradient from encode_gradient() method that contains the field elements converted from floating point numbers, and also the bits for L2-norm check. But when we unpack the encoded measurement in eval(), we refer to encoded_gradient as the field elements converted from floating point numbers only. It would be good to distinguish between the two.

cjpatton commented 6 months ago

Good catch! As suggested in the call today: consider renaming to encode_gradient_and_range_checked_norm(), or maybe just encode_gradient_and_norm(). Make sure to also replace each instance of the variable encoded_gradient that also has the norm in it with something distinctive.

junyechen1996 commented 6 months ago

Closed by #68 .