search

junzis / pyModeS

Python decoder for Mode S and ADS-B signals
GNU General Public License v3.0
527 stars 151 forks source link

Unused imports #130

Closed dforsi closed 1 year ago

dforsi commented 1 year ago

The pylint tools reports unused imports. Below I'm copying two separate lists unused-import and unused-wildcard-import.

For adsb.py, commb.py, and surv.py it isn't clear if the comments should be updated to reflect the modules actually imported (eg. bds61 and bds62 in in adsb.py) or if the imports should be removed (eg. fs, dr, um in commb.py and surv.py).

$ pylint --disable=all --enable=unused-import pyModeS/ tests/
************* Module pyModeS.decoder.adsb
pyModeS/decoder/adsb.py:12:0: W0611: Unused pyModeS imported as pms (unused-import)
pyModeS/decoder/adsb.py:29:0: W0611: Unused category imported from pyModeS.decoder.bds.bds08 (unused-import)
pyModeS/decoder/adsb.py:29:0: W0611: Unused callsign imported from pyModeS.decoder.bds.bds08 (unused-import)
pyModeS/decoder/adsb.py:30:0: W0611: Unused altitude_diff imported from pyModeS.decoder.bds.bds09 (unused-import)
pyModeS/decoder/adsb.py:31:0: W0611: Unused is_emergency imported from pyModeS.decoder.bds.bds61 (unused-import)
pyModeS/decoder/adsb.py:31:0: W0611: Unused emergency_state imported from pyModeS.decoder.bds.bds61 (unused-import)
pyModeS/decoder/adsb.py:31:0: W0611: Unused emergency_squawk imported from pyModeS.decoder.bds.bds61 (unused-import)
pyModeS/decoder/adsb.py:32:0: W0611: Unused selected_altitude imported from pyModeS.decoder.bds.bds62 (unused-import)
pyModeS/decoder/adsb.py:32:0: W0611: Unused selected_heading imported from pyModeS.decoder.bds.bds62 (unused-import)
pyModeS/decoder/adsb.py:32:0: W0611: Unused target_altitude imported from pyModeS.decoder.bds.bds62 (unused-import)
pyModeS/decoder/adsb.py:32:0: W0611: Unused target_angle imported from pyModeS.decoder.bds.bds62 (unused-import)
pyModeS/decoder/adsb.py:32:0: W0611: Unused tcas_operational imported from pyModeS.decoder.bds.bds62 (unused-import)
pyModeS/decoder/adsb.py:32:0: W0611: Unused tcas_ra imported from pyModeS.decoder.bds.bds62 (unused-import)
pyModeS/decoder/adsb.py:32:0: W0611: Unused baro_pressure_setting imported from pyModeS.decoder.bds.bds62 (unused-import)
pyModeS/decoder/adsb.py:32:0: W0611: Unused vertical_mode imported from pyModeS.decoder.bds.bds62 (unused-import)
pyModeS/decoder/adsb.py:32:0: W0611: Unused horizontal_mode imported from pyModeS.decoder.bds.bds62 (unused-import)
pyModeS/decoder/adsb.py:32:0: W0611: Unused vnav_mode imported from pyModeS.decoder.bds.bds62 (unused-import)
pyModeS/decoder/adsb.py:32:0: W0611: Unused lnav_mode imported from pyModeS.decoder.bds.bds62 (unused-import)
pyModeS/decoder/adsb.py:32:0: W0611: Unused autopilot imported from pyModeS.decoder.bds.bds62 (unused-import)
pyModeS/decoder/adsb.py:32:0: W0611: Unused altitude_hold_mode imported from pyModeS.decoder.bds.bds62 (unused-import)
pyModeS/decoder/adsb.py:32:0: W0611: Unused approach_mode imported from pyModeS.decoder.bds.bds62 (unused-import)
pyModeS/decoder/adsb.py:32:0: W0611: Unused emergency_status imported from pyModeS.decoder.bds.bds62 (unused-import)
************* Module pyModeS.decoder.commb
pyModeS/decoder/commb.py:40:0: W0611: Unused fs imported from pyModeS.py_common (unused-import)
pyModeS/decoder/commb.py:40:0: W0611: Unused dr imported from pyModeS.py_common (unused-import)
pyModeS/decoder/commb.py:40:0: W0611: Unused um imported from pyModeS.py_common (unused-import)
************* Module pyModeS.decoder.surv
pyModeS/decoder/surv.py:6:0: W0611: Unused fs imported from pyModeS.py_common (unused-import)
pyModeS/decoder/surv.py:6:0: W0611: Unused dr imported from pyModeS.py_common (unused-import)
pyModeS/decoder/surv.py:6:0: W0611: Unused um imported from pyModeS.py_common (unused-import)

------------------------------------------------------------------
$ pylint --disable=all --enable=unused-wildcard-import pyModeS/ tests/
************* Module pyModeS.decoder.els
pyModeS/decoder/els.py:13:0: W0614: Unused import(s) is10, ovc10 and common from wildcard import of pyModeS.decoder.bds.bds10 (unused-wildcard-import)
pyModeS/decoder/els.py:14:0: W0614: Unused import(s) is17 and cap17 from wildcard import of pyModeS.decoder.bds.bds17 (unused-wildcard-import)
pyModeS/decoder/els.py:15:0: W0614: Unused import(s) is20 and cs20 from wildcard import of pyModeS.decoder.bds.bds20 (unused-wildcard-import)
pyModeS/decoder/els.py:16:0: W0614: Unused import(s) is30 from wildcard import of pyModeS.decoder.bds.bds30 (unused-wildcard-import)
************* Module pyModeS.decoder.commb
pyModeS/decoder/commb.py:26:0: W0614: Unused import(s) is10, ovc10 and common from wildcard import of pyModeS.decoder.bds.bds10 (unused-wildcard-import)
pyModeS/decoder/commb.py:27:0: W0614: Unused import(s) is17 and cap17 from wildcard import of pyModeS.decoder.bds.bds17 (unused-wildcard-import)
pyModeS/decoder/commb.py:28:0: W0614: Unused import(s) is20 and cs20 from wildcard import of pyModeS.decoder.bds.bds20 (unused-wildcard-import)
pyModeS/decoder/commb.py:29:0: W0614: Unused import(s) is30 from wildcard import of pyModeS.decoder.bds.bds30 (unused-wildcard-import)
pyModeS/decoder/commb.py:32:0: W0614: Unused import(s) warnings, is40, selalt40mcp, selalt40fms, p40baro, alt40mcp and alt40fms from wildcard import of pyModeS.decoder.bds.bds40 (unused-wildcard-import)
pyModeS/decoder/commb.py:33:0: W0614: Unused import(s) is50, roll50, trk50, gs50, rtrk50 and tas50 from wildcard import of pyModeS.decoder.bds.bds50 (unused-wildcard-import)
pyModeS/decoder/commb.py:34:0: W0614: Unused import(s) is60, hdg60, ias60, mach60, vr60baro, vr60ins and aero from wildcard import of pyModeS.decoder.bds.bds60 (unused-wildcard-import)
pyModeS/decoder/commb.py:37:0: W0614: Unused import(s) is44, wind44, temp44, p44, hum44 and turb44 from wildcard import of pyModeS.decoder.bds.bds44 (unused-wildcard-import)
pyModeS/decoder/commb.py:38:0: W0614: Unused import(s) is45, turb45, ws45, mb45, ic45, wv45, temp45, p45 and rh45 from wildcard import of pyModeS.decoder.bds.bds45 (unused-wildcard-import)
************* Module pyModeS.decoder.ehs
pyModeS/decoder/ehs.py:14:0: W0614: Unused import(s) is40, selalt40mcp, selalt40fms, p40baro, alt40mcp, alt40fms and common from wildcard import of pyModeS.decoder.bds.bds40 (unused-wildcard-import)
pyModeS/decoder/ehs.py:15:0: W0614: Unused import(s) is50, roll50, trk50, gs50, rtrk50 and tas50 from wildcard import of pyModeS.decoder.bds.bds50 (unused-wildcard-import)
pyModeS/decoder/ehs.py:16:0: W0614: Unused import(s) is60, hdg60, ias60, mach60, vr60baro, vr60ins and aero from wildcard import of pyModeS.decoder.bds.bds60 (unused-wildcard-import)

------------------------------------------------------------------
junzis commented 1 year ago

this is to support easy import for end users